Follow

@z3ntu Oh, yes! Sorry, this year is a tough one and I'm quite absent from coding. I'm far from any computer right now, but I'll give it a shot between today late, 👍

@RoboePi I'm sorry but this Makefile is horrible. Not directly YOUR Makefile but in general Makefiles... Make is doing whatever it wants to do...

@RoboePi Okay well half of it was my fault for copy pasting but still, Makefiles aren't really transparent in what they are doing imo

@RoboePi Also I've updated the PR with your suggestions

@z3ntu It looks good now! There's a blank line in L49 I'm not sure about…
I'll approve it in a couole of days, once I can build and flash it, 👌
Thanks! 😊

@RoboePi Would be especially great to 18.10.0 out as it has the bootloader fix to fix the restart out of the charging mode

@z3ntu Yeah, I can understand that. I kind of like it now because of its file-based declarativeness, but had the same opinion before learning to "tame" it (and getting to know its limitations). You got a fair point there, though: it has a high entry barrier to collaboration… I'm open to other alternatives for the future if you know other lang-agnostic build tool.

@RoboePi I'm kind of in favor of the shell script that was there before the makefile... Other ideas are python (unnecessarily complicated probably) or a meson script (at least it has proper find_program statements or whatever - but also probably overkill and overcomplicated)

Hmm, I don't like the shell script, really. More: 

@z3ntu It downloads the update ZIPs each time, it's quite imperative and chronological (vs declarative and tree-based). I think that most of the issues we have with Make are caused because we use it directly, instead of relying on CMake or Automake, but I found those overcomplicated for such a small project. Anyway, this is definitely a conversation we can have. Do you want to open an issue? Also, I think PR#6 is relevant: github.com/WeAreFairphone/mode

@RoboePi about it downloading the zip every time: that is solved by a simple if. And I'm pretty sure using a proper build system for basically just calling shell command is completely unnecessary and way too complicated (same with eg a python script).

Sign in to participate in the conversation
Mastodon

Server run by the main developers of the project 🐘 It is not focused on any particular niche interest - everyone is welcome as long as you follow our code of conduct!